Introduction
We express our gratitude to the Acta Finance team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Acta Finance is a DeFi ecosystem that brings innovation to the DeFi industry by motivating users to build a referral network that rewards user network, and user activity, through the referral system and address milestones.
| title | content |
|---|---|
| Platform | EVM |
| Language | Solidity |
| Timeline | 12/04/2022 - 04/05/2022 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/P2P-Finance/acta-nft-token.git→ |
| Commit | 428d82167ead9932b7b30068b279c2369a3cad9b |
Review Scope
- Commit
- 428d82167ead9932b7b30068b279c2369a3cad9b
Audit Summary
10/10
10/10
10/10
5/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for Acta Finance |
| Audited By | Hacken |
| Website | https://actafi.org/→ |
| Changelog | 15/04/2022 - Initial Review |
| 29/04/2022 - Second Review | |
| 05/05/2022 - Third Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Acta Finance
- Audited By
- Hacken
- Website
- https://actafi.org/→
- Changelog
- 15/04/2022 - Initial Review
- 29/04/2022 - Second Review
- 05/05/2022 - Third Review
System Overview
Acta Finance is a DeFi ecosystem that brings innovation to the DeFi industry by motivating users to build a referral network that rewards user network, and user activity, through the referral system and address milestones. ActaFi Swap is a cross-chain liquidity aggregator that offers margin trading that receives the margin from peer-to-peer lending offers, introducing a new investment opportunity for the users.
ActaNftToken — a contract that implements the ERC721 contract. Minting is available only for allowed by contract owner roles with any URI for NFT image.
Privileged roles
Owner can assign roles for NFT minting.
Owner can pause the contract in case of any errors to stop minting.
Executive Summary
Documentation quality
The total Documentation quality score is 5 out of 10.
The Customer provided a whitepaper with functional requirements. The whitepaper does not contain any information about NFTs.
Code quality
The total Code quality score is 10 out of 10.
Good unit tests coverage were provided.
Architecture quality
The Architecture quality score is 10 out of 10.
The project has clear and clean architecture.
Security score
Upon auditing, the code was found to contain 0 critical, 2 high, 0 medium, and 4 low severity issues, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 9.5. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2022-1553 | Mint is available for everyone | fixed | High | |
| F-2022-1552 | NFT id’s collision is possible | fixed | High | |
| F-2022-1557 | Floating Pragma | fixed | Low | |
| F-2022-1556 | Redundant import | fixed | Low | |
| F-2022-1555 | Improper Input Validation | unfixed | Low | |
| F-2022-1554 | Public function that could be declared external | fixed | Low |
Identify vulnerabilities in your smart contracts.
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/P2P-Finance/acta-nft-token.git→ |
| Commit | 428d82167ead9932b7b30068b279c2369a3cad9b |
| Whitepaper | Provided |
| Technical Requirements | Provided |
Scope Details
- Commit
- 428d82167ead9932b7b30068b279c2369a3cad9b
- Whitepaper
- Provided
- Technical Requirements
- Provided