Introduction
We express our gratitude to the Trivians team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Trivians is the new generation crypto powered Trivia gaming platform. It is a metaverse, where players play as Trivian characters and earn Trivian Tokens.
| title | content |
|---|---|
| Platform | EVM |
| Language | Solidity |
| Tags | BEP20; Vesting |
| Timeline | 13/06/2022 - 01/07/2022 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/tanselkaya/TrivianToken→ |
| Commit | be7968ce9aea8afeb26ac6149a32142fed4d552f |
Review Scope
- Commit
- be7968ce9aea8afeb26ac6149a32142fed4d552f
Audit Summary
9/10
10/10
8/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for Trivians |
| Audited By | Hacken |
| Website | https://trivians.io/→ |
| Changelog | 17/06/2022 - Initial Review |
| 01/07/2022 - Second Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Trivians
- Audited By
- Hacken
- Website
- https://trivians.io/→
- Changelog
- 17/06/2022 - Initial Review
- 01/07/2022 - Second Review
System Overview
Trivians is a cryptocurrency-powered trivia game app that enables players to win Trivian Token according to their correct answers at different game modes and competitions. It is the new generation trivia game, with a totally unique “Battle Royale” approach without any geographical and language restrictions. The system consists of the following contracts:
TrivianToken — a simple ERC-20 token that mints all initial supply to a deployer. Additional minting is not allowed. It has the following attributes:
Name: Trivian Token
Symbol: TRIVIA
Decimals: 3
Total supply: 1b tokens.
TokenVesting — a contract that is responsible for the control of vesting periods and unlocks.
Privileged roles
The owner of the TrivianToken contract can pause all token transactions.
The owner of the TokenVesting contract can revoke the vesting schedule for a specific identifier.
The owner of the TokenVesting contract can withdraw excess tokens from the vesting pool.
The owner of the TokenVesting contract can create a vesting schedule for a beneficiary.
The owner of the TokenVesting contract can withdraw ERC20 tokens from the contract.
Executive Summary
Documentation quality
The total Documentation quality score is 10 out of 10.
The whitepaper is provided.
Vesting periods are well-described.
Code quality
The total Code quality score is 8 out of 10.
Deployment and user interactions are covered with tests.
Missing some validations.
A redundant cast exists.
Architecture quality
The Architecture quality score is 10 out of 10.
Code follows the single responsibility principle.
Code is well structured, and well commented.
Security score
Upon auditing, the code was found to contain 0 critical, 0 high, 2 medium, and 5 low severity issues. Out of these, 7 issues have been addressed and resolved, leading to a security score of 9 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 9.1. This score reflects the combined evaluation of documentation, code quality, architecture quality, and security aspects of the project.
Risks
In case of an admin keys leak, an attacker can lock all token transactions or change vestings.
Vesting addresses and periods will be configured after the contract deployment. It is impossible to verify that all vestings would be declared as per provided documentation.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2022-1757 | Funds stuck in the contract | fixed | Medium | |
| F-2022-1756 | Unnecessary SafeMath usage | fixed | Medium | |
| F-2022-1762 | Missing vesting validation | fixed | Low | |
| F-2022-1761 | Redundant payable address cast | fixed | Low | |
| F-2022-1760 | Zero address is allowed | fixed | Low | |
| F-2022-1759 | Public functions could be declared external | fixed | Low | |
| F-2022-1758 | Floating Pragma | fixed | Low |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/tanselkaya/TrivianToken→ |
| Commit | be7968ce9aea8afeb26ac6149a32142fed4d552f |
| Whitepaper | Provided→ |
| Requirements | Provided (partially) |
| Technical Requirements | Provided |
Scope Details
- Commit
- be7968ce9aea8afeb26ac6149a32142fed4d552f
- Whitepaper
- Provided→
- Requirements
- Provided (partially)
- Technical Requirements
- Provided