Introduction
We express our gratitude to the S3Money team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
TONE is a token project that contains multiple functionalities, such as minting, burning, freezing, and allocating. It differentiates these functionalities with a strong role-based access control implementation. TONE is a token project that contains multiple functionalities like minting, burning, freezing, and allocating. It splits these functionalities with a strong Role-based Access Control implementation.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for S3Money |
| Audited By | Ataberk Yavuzer |
| Approved By | Grzegorz Trawinski |
| Website | N/A |
| Changelog | 27/12/2024 - Preliminary Report |
| 06/01/2025 - Final Report | |
| Platform | Sui |
| Language | Move |
| Tags | ERC-20 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for S3Money
- Audited By
- Ataberk Yavuzer
- Approved By
- Grzegorz Trawinski
- Website
- N/A
- Changelog
- 27/12/2024 - Preliminary Report
- 06/01/2025 - Final Report
- Platform
- Sui
- Language
- Move
- Tags
- ERC-20
- Methodology
- https://hackenio.cc/sc_methodology→
Review Scope | |
|---|---|
| Repository | https://github.com/PravicaInc/s3-core→ |
| Initial Commit | a21d199 |
| Retest Commit | f90a9d2e26657ce4e2597bacb2999b6da748d7a5 |
Review Scope
- Repository
- https://github.com/PravicaInc/s3-core→
- Initial Commit
- a21d199
- Retest Commit
- f90a9d2e26657ce4e2597bacb2999b6da748d7a5
Audit Summary
The system users should acknowledge all the risks summed up in the risks section of the report.
Documentation quality
Functional requirements are provided.
Technical description is provided.
Code quality
The code duplicates commonly known contracts.
Several template code patterns were found.
The development environment is fully-configured.
Test coverage
Code coverage for the project cannot be measured due to a lack of a coverage environment. However,
Most of function interactions were covered.
Interactions by several users were tested.
System Overview
TONE is a token project with the following contracts:
cash_.move — The cash contract that creates new cash-in structs and tracks them.
denylist_rule.move — The denylist contract allows users who hold the TokenPolicyCap capability to deny transfers.
pauser_rule.move — The pauser contract manages the pausing state, which affects transfers in case of an emergency.
token_supply.move — The token supply contract that manages supply shares and maximum supply amount in the protocol.
tone.move — The main token contract that combines and uses all contracts above.
It has the following attributes:
Name: TONE Coin
Symbol: $TONE
Decimals: 2
Total supply: 100000 (can be defined as finite or infinite; finite on hardcoded config)
Privileged roles
The
TreasuryCap:Mint operations
Burn operations
Can create a new currency with hardcoded settings in the TONE contract
The
TokenPolicyCap:Pauses/unpauses the contract
Freezes/unfreezes addresses to prevent transfers for specific users
The
CasherCap:Can call the
allocate()function to hold the address of casher's wallet address.
Potential Risks
The only significant risk present in in-scope contracts relates to access controls. The protocol currently employs Role-based Access Control (RBAC) for privileged functions such as minting, burning, and supply updates. Due to the design of the Sui language, these roles are assigned specific capabilities to users during the initialization of the contract. If these user addresses are compromised, these roles can be exploited for malicious purposes.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2024-7987 | Presence of Commented-Out Code | fixed | Observation | |
| F-2024-7963 | Potential Integer Overflow | fixed | Observation | |
| F-2024-7962 | Confusing Natspec | fixed | Observation | |
| F-2024-7961 | Unchecked Return Value | mitigated | Observation |
Appendix 1. Definitions
Severities
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution.
Potential Risks
The "Potential Risks" section identifies issues that are not direct security vulnerabilities but could still affect the project’s performance, reliability, or user trust. These risks arise from design choices, architectural decisions, or operational practices that, while not immediately exploitable, may lead to problems under certain conditions. Additionally, potential risks can impact the quality of the audit itself, as they may involve external factors or components beyond the scope of the audit, leading to incomplete assessments or oversight of key areas. This section aims to provide a broader perspective on factors that could affect the project's long-term security, functionality, and the comprehensiveness of the audit findings.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/PravicaInc/s3-core→ |
| Commit | a21d19936fe7be2f9e6945e396ce46ba575d8803 |
| Whitepaper | N/A |
| Requirements | N/A |
| Technical Requirements | https://pravica.notion.site/Smart-Contract-Development-1583712e6bb1801387dcddebb4048b16→ |
Scope Details
- Repository
- https://github.com/PravicaInc/s3-core→
- Commit
- a21d19936fe7be2f9e6945e396ce46ba575d8803
- Whitepaper
- N/A
- Requirements
- N/A
- Technical Requirements
- https://pravica.notion.site/Smart-Contract-Development-1583712e6bb1801387dcddebb4048b16→
Assets in Scope
Appendix 3. Additional Valuables
The smart contracts in the scope of this audit could benefit from the introduction of automatic emergency actions for critical activities, such as unauthorized operations like ownership changes, including large withdrawals or minting events. Adding such mechanisms would enable the protocol to react automatically to unusual activity, ensuring the contract remains secure and functions as intended.
To improve functionality, these emergency actions could be designed to trigger under specific conditions, such as:
Detecting changes to ownership or critical permissions.
Monitoring large or unexpected transactions and minting events.
Pausing operations when irregularities are identified.
These enhancements would provide an added layer of security, making the contract more robust and better equipped to handle unexpected situations while maintaining smooth operations.