Audit name:
[SCA] Pikamoon / ERC20 / Mar2024
Date:
Mar 20, 2024
Table of Content
Introduction
We express our gratitude to the Pikamoon team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Pikamoon is a GameFi token with a focus on community.
| title | content |
|---|---|
| Platform | EVM |
| Language | Solidity |
| Tags | ERC20, Upgradable |
| Timeline | 04/03/2024 - 06/03/2024 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/orbit-cosmos/PikaMoon→ |
| Commit | d1875af2d9c17470ed72eb507aa3dd6af3f2bb5b |
| Remediation Commit | edc11f1d91fea7002f77426693ee434be0de7971 |
Review Scope
- Commit
- d1875af2d9c17470ed72eb507aa3dd6af3f2bb5b
- Remediation Commit
- edc11f1d91fea7002f77426693ee434be0de7971
Audit Summary
10/10
46.77%
10/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for Pikamoon |
| Audited By | Niccolò Pozzolini, Kornel Światłowski |
| Approved By | Przemyslaw Swiatowiec |
| Website | https://www.pikamoon.io/→ |
| Changelog | 05/03/2024 - Preliminary Report; 06/03/2024 Second Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Pikamoon
- Audited By
- Niccolò Pozzolini, Kornel Światłowski
- Approved By
- Przemyslaw Swiatowiec
- Website
- https://www.pikamoon.io/→
- Changelog
- 05/03/2024 - Preliminary Report; 06/03/2024 Second Review
System Overview
PikaMoon — simple ERC20 token contract that allows minting and burning of tokens.
It has the following attributes:
Name: Pikamoon
Symbol: PIKA
Decimals: 9
Total supply: 50000000_000 tokens.
Privileged roles
PikaMoon contract uses a AccessControlUpgradeable library from OpenZeppelin to restrict access to important functions. There is defined OWNER_ROLE and addresses with this role can:
set Automated MarketMaker pair,
mint new tokens and assign them to a specified address,
burn existing tokens from a specified owner's balance,
change fee multiply,
set ecosystem address,
set marketing address,
update isExcludeFromTax mapping to exclude or include from tax,
toggle on/off tax
set marketing tax,
set eco system tax,
set burn tax
Executive Summary
Documentation quality
The total Documentation Quality score is 10 out of 10.
Functional requirements are complete.
Technical description is provided.
Code quality
The total Code Quality score is 10 out of 10.
The development environment is configured.
Test coverage
Code coverage of the project is 46.77% (branch coverage).
Negative cases coverage is missed.
Some functions are not tested.
Security score
Upon auditing, the code was found to contain 0 critical, 0 high, 2 medium, and 2 low severity issues. All issues were fixed in the remediation part of auditing process, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 10. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
PikaMoon contract is upgradeable: the owner can change the logic at any time, possibly affecting user balances.
The project whitepaper precisely details the PikaMoon tokenomics, but a vesting contract is lacking from the provided repository and thus cannot be verified.
The Solidity version 0.8.20 employs the recently introduced PUSH0 opcode in the Shanghai EVM. This opcode might not be universally supported across all blockchain networks and Layer 2 solutions. Thus, as a result, it might be not possible to deploy solution with version 0.8.20 >= on some blockchains.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2024-1272 | Several supposedly constant variables can be modified | fixed | Medium | |
| F-2024-1211 | The OWNER_ROLE can burn tokens from users | fixed | Medium | |
| F-2024-1273 | Misuse of the feeMultiply variable | fixed | Low | |
| F-2024-1243 | Missing validation of tax value in tax setters functions | fixed | Low | |
| F-2024-1276 | Redundant nested if structure and unnecessary assignments in calculateTax function | fixed | Observation | |
| F-2024-1208 | Missing events emitting for critical functions | fixed | Observation | |
| F-2024-1207 | Public functions that should be external | fixed | Observation | |
| F-2024-1204 | Redundant imports | fixed | Observation | |
| F-2024-1203 | Floating Pragma | fixed | Observation |
Identify vulnerabilities in your smart contracts.
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/orbit-cosmos/PikaMoon→ |
| Commit | d1875af2d9c17470ed72eb507aa3dd6af3f2bb5b |
| Whitepaper | https://docs.pikamoon.io/→ |
| Requirements | https://github.com/orbit-cosmos/PikaMoon/blob/master/docs/index.md→ |
| Technical Requirements | https://github.com/orbit-cosmos/PikaMoon/blob/master/docs/index.md→ |
Scope Details
- Commit
- d1875af2d9c17470ed72eb507aa3dd6af3f2bb5b
- Whitepaper
- https://docs.pikamoon.io/→
- Technical Requirements
- https://github.com/orbit-cosmos/PikaMoon/blob/master/docs/index.md→
Contracts in Scope
contracts/PikaMoon.solcontracts/interfaces/IPikaMoon.solcontracts/interfaces/IUniswapV2Router02.solcontracts/libraries/Errors.sol