Introduction
We express our gratitude to the Paydece team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Paydece is a decentralized Peer to Peer payment gateway with smart contracts that allows users to exchange goods and services using the crypto they hold in their self-custodial wallet.
title | content |
---|---|
Platform | Ethereum, BSC, Polygon, RSK |
Language | Solidity |
Tags | Escrow |
Timeline | 17/01/2023 - 01/03/2023 |
Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
---|---|
Repository | https://github.com/PayDece/paydece-contracts→ |
Commit | 3f6775db80cf7905dfa3443fe2ebf606e1a235f7 |
Review Scope
- Commit
- 3f6775db80cf7905dfa3443fe2ebf606e1a235f7
Audit Summary
10/10
86.26%
10/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
---|---|
Name | Smart Contract Code Review and Security Analysis Report for Paydece |
Audited By | Hacken |
Website | http://paydece.io/→ |
Changelog | 17/01/2023 – Initial Review |
03/02/2023 - Second Review | |
16/02/2023 - Third Review | |
01/03/2023 - Fourth Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Paydece
- Audited By
- Hacken
- Website
- http://paydece.io/→
- Changelog
- 17/01/2023 – Initial Review
- 03/02/2023 - Second Review
- 16/02/2023 - Third Review
- 01/03/2023 - Fourth Review
System Overview
Paydece is an escrow system with the following contracts:
PaydeceEscrowV3 — an escrow contract that allows creating new escrows of USDT tokens using other coins or native tokens.
USDTToken — a USDT token for test purposes.
Privileged roles
The owner of the PaydeceEscrowV3 contract can set fees for buyers and sellers, release escrows, refund buyers, withdraw fees, add and delete addresses of tokens.
Executive Summary
Documentation quality
The total Documentation quality score is 10 out of 10.
Code quality
The total Code quality score is 10 out of 10.
The development environment is configured.
The code is compliant with Solidity Code Style guide.
Test coverage
Code coverage of the project is 86.36% (branch coverage).
Code coverage is sufficient.
Security score
Upon auditing, the code was found to contain 0 critical, 3 high, 1 medium, and 2 low severity issues. Out of these, 6 issues have been addressed and resolved, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 9.5. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
The system can accept any ERC-20 token for escrow but is not designed to work with fee-on-transfer tokens and assume a value passed as a parameter as an actual value transferred. The project owners should ensure that such tokens are never added to a whitelist.
Findings
Code ― | Title | Status | Severity | |
---|---|---|---|---|
F-2023-118 | Unfinalized Code | fixed | High | |
F-2023-1183 | Requirements Violation | fixed | High | |
F-2023-1182 | Highly Permissive Role Access | fixed | High | |
F-2023-1185 | Usage of Built-In Transfer | fixed | Medium | |
F-2023-118 | Check-Effect-Interaction Pattern Violation | fixed | Low | |
F-2023-118 | Floating Pragma | fixed | Low |
Identify vulnerabilities in your smart contracts.
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
---|---|
Repository | https://github.com/PayDece/paydece-contracts→ |
Commit | 3f6775db80cf7905dfa3443fe2ebf606e1a235f7 |
Whitepaper | Not provided |
Requirements | Provided→ |
Technical Requirements | Provided→ |
Contracts in Scope
contracts/PaydeceEscrowV3.sol
contracts/USDTToken.sol