Introduction
We express our gratitude to the Wormfare team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Wormfare is a next-level gaming experience that goes beyond just play-to-earn. Wormfare offers a unique blend of engaging gameplay, crypto incentives, and magical community quests.
title | content |
---|---|
Platform | EVM |
Language | Solidity |
Tags | ERC20 Presale |
Timeline | 22/02/2024 - 06/03/2024 |
Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
---|---|
Repository | https://github.com/wormfare/contracts/commits/main/→ |
Commit | a2b19943777bc505f22e84acdac50ca13b54d6e0 |
Remediation Commit | 39c93e85367d911a7146ea27c70fc0b860df6d2a |
Review Scope
- Commit
- a2b19943777bc505f22e84acdac50ca13b54d6e0
- Remediation Commit
- 39c93e85367d911a7146ea27c70fc0b860df6d2a
Audit Summary
10/10
98%
10/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
---|---|
Name | Smart Contract Code Review and Security Analysis Report for Wormfare |
Audited By | Niccolò Pozzolini, Kornel Światłowski |
Approved By | Przemyslaw Swiatowiec |
Website | https://wormfare.com/→ |
Changelog | 26/02/2024 - Preliminary Report; 06/03/2024 - Second Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Wormfare
- Audited By
- Niccolò Pozzolini, Kornel Światłowski
- Approved By
- Przemyslaw Swiatowiec
- Website
- https://wormfare.com/→
- Changelog
- 26/02/2024 - Preliminary Report; 06/03/2024 - Second Review
System Overview
TokenSale is a smart contract that lets its owners presale an ERC20 token before the actual token is issued. The contract allows users to purchase tokens with USDT, incorporating discount and referral reward mechanisms. The contract works with a backend API that produces and signs the parameters for a user when they want to make a purchase. All USDT received except the referral reward part is transferred to a “treasury” wallet specified during the contract deployment. After purchase, users do not receive actual tokens, the contract only tracks user token balances.
Privileged roles
TokenSale contract uses the AccessControlUpgradeable library from OpenZeppelin to restrict access to important functions. The contract contains DEFAULTADMINROLE that can:
pause and unpause contract,
update apiSigner address,
update token price in USDT,
buy tokens for someone else without generated signature
Executive Summary
Documentation quality
The total Documentation Quality score is 10 out of 10.
Functional requirements are detailed.
Technical description is robust.
Code quality
The total Code Quality score is 10 out of 10.
Test coverage
Code coverage of the project is 98.53% (branch coverage)
Deployment and basic user interactions are covered with tests.
Negative cases are covered.
Security score
Upon auditing, the code was found to contain 0 critical, 0 high, 0 medium, and 3 low severity issues, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 10. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
No additional risks were identified.
Findings
Code ― | Title | Status | Severity | |
---|---|---|---|---|
F-2024-1031 | Checks-Effects-Interactions pattern violation | fixed | Low | |
F-2024-1029 | Backend API takeover can lead to unlimited token purchase for free | fixed | Low | |
F-2024-1027 | Lack of Parameter Validation in initialize, setApiSigner, and setTokenPriceUsdt Functions | fixed | Low | |
F-2024-1030 | DEFAULTADMINROLE can frontrun buy() transaction | fixed | Observation | |
F-2024-1028 | Redundant Math in Token Sale Calculation | fixed | Observation | |
F-2024-1026 | Misleading Parameter Name and Lack of Detailed Information in NatSpec | fixed | Observation | |
F-2024-1024 | Missing events emitting for critical functions | fixed | Observation | |
F-2024-1023 | Public functions that should be external | fixed | Observation | |
F-2024-1022 | Floating pragma | fixed | Observation | |
F-2024-1021 | Gas inefficiency due to missing usage of Solidity custom errors | fixed | Observation |
Identify vulnerabilities in your smart contracts.
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
---|---|
Repository | https://github.com/wormfare/contracts/commits/main/→ |
Commit | a2b19943777bc505f22e84acdac50ca13b54d6e0 |
Whitepaper | https://whitepaper.wormfare.com/→ |
Requirements | https://github.com/wormfare/contracts/tree/main/docs→ |
Technical Requirements | https://github.com/wormfare/contracts/tree/main/docs→ |
Scope Details
- Commit
- a2b19943777bc505f22e84acdac50ca13b54d6e0
- Whitepaper
- https://whitepaper.wormfare.com/→
- Technical Requirements
- https://github.com/wormfare/contracts/tree/main/docs→