Audit name:
[SCA] VitalTale | ERC20 | Sep2023
Date:
Oct 8, 2023
Table of Content
Introduction
We express our gratitude to the VitalTale team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
VITALTALE is a social platform of the Web 3.0 generation integrating telemedicine tools and semantic markup based on ICD-10, allowing people from all over the world to solve their health problems, receive valuable information, contribute to the improvement of quality and increase in life expectancy.
| title | content |
|---|---|
| Platform | EVM |
| Language | Solidity |
| Tags | ERC20 |
| Timeline | 13/09/2023 - 10/10/2023 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | N/A, files were provided as a zipped package. |
| Commit | N/A |
Review Scope
- Repository
- N/A, files were provided as a zipped package.
- Commit
- N/A
Audit Summary
7/10
100%
9/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for VitalTale |
| Audited By | Hacken |
| Website | N/A |
| Changelog | 20/09/2023 - Initial Review |
| 10/10/2023 - Second Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for VitalTale
- Audited By
- Hacken
- Website
- N/A
- Changelog
- 20/09/2023 - Initial Review
- 10/10/2023 - Second Review
System Overview
VitalTale is a protocol with the following contracts:
VITALTALE — simple ERC-20 token with custom minting mechanism. Minting is allowed for the user with the MINTERROLE after the mint config is set by the DEFAULTADMIN_ROLE. It has the following attributes:
Name: VITALTALE.
Symbol: VTTL.
Decimals: 18.
AntiSnipe — a whitelist contract for blocking ERC-20 transfers performed by non-whitelisted addresses.
Privileged roles
The DEFAULTADMINROLE of the VITALTALE contract can update mint config and payment config, enable/disable antisnipe (whitelist) feature and change the antisnipe contract address.
The MINTER_ROLE of the VITALTALE contract can perform mintings after the mint config is set by the admin.
The owner of the AntiSnipe contract can add and remove addresses from the whitelist.
Executive Summary
Documentation quality
The total Documentation quality score is 7 out of 10.
Functional requirements are provided.
Technical description is provided.
Natspec comments are not included.
Code quality
The total Code quality score is 9 out of 10.
Solidity Style Guide is not being followed (I02).
Test coverage
Code coverage of the project is 100% (branch coverage).
Tests are not required for projects with less than 250 lines of code.
Security score
Upon auditing, the code was found to contain 0 critical, 0 high, 1 medium, and 1 low severity issues. Out of these, 2 issues have been addressed and resolved, leading to a Security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 9.5. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
No risks were identified.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2023-0900 | Missing Input Validations: setPaymentConfig() | fixed | Medium | |
| F-2023-0901 | Missing Events on Critical State Updates | fixed | Low | |
| I-2023-0221 | Functions That Should Be Declared External | fixed | Observation | |
| I-2023-0220 | Functions That Should Be Declared View | fixed | Observation | |
| I-2023-0219 | Unused Function Arguments | fixed | Observation | |
| I-2023-0218 | Solidity Style Guide Violation: Order Of Layout | unfixed | Observation | |
| I-2023-0217 | Floating Pragma | fixed | Observation |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | N/A, files were provided as a zipped package. |
| Commit | N/A |
| Contract Address | https://arbiscan.io/address/0xB0f778A62d0DA8d7a6Ac03d390c47f2D85c386c1→ |
| Whitepaper | Not provided |
| Requirements | Provided→ |
| Technical Requirements | Not provided |
Scope Details
- Repository
- N/A, files were provided as a zipped package.
- Commit
- N/A
- Whitepaper
- Not provided
- Requirements
- Provided→
- Technical Requirements
- Not provided