- Hacken
- Audits
- venom-foundation
- [SCA] Web3.World | Vesting | Aug2023
Audit name:
[SCA] Web3.World | Vesting | Aug2023
Date:
Aug 29, 2023
Table of Content
Introduction
We express our gratitude to the Venom Foundation team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Web3.World is an Automated Market Maker, Yield Farming, and Staking platform built on Venom blockchain.
| title | content |
|---|---|
| Platform | TON, Venom |
| Language | TON-Solidity |
| Tags | Vesting |
| Timeline | 04/08/2023 - 28/08/2023 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/venom-blockchain/vesting→ |
| Commit | 871af51db9c58c8054cb144aea0d4c2f368f692b |
Review Scope
- Commit
- 871af51db9c58c8054cb144aea0d4c2f368f692b
Audit Summary
10/10
85%
9/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for Venom Foundation |
| Audited By | Hacken |
| Website | http://web3.world/vesting→ |
| Changelog | 11/08/2023 – Initial Review |
| 28/08/2023 – Second Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Venom Foundation
- Audited By
- Hacken
- Website
- http://web3.world/vesting→
- Changelog
- 11/08/2023 – Initial Review
- 28/08/2023 – Second Review
System Overview
Venom Vesting — a smart contract system allowing vesting contracts creation and management.
In-scope contracts:
IndexFactory & Index — contracts that provide an ability to list decentralized data.
VestingFactory (inherit IndexFactory) — contract allows Vesting and NativeVesting contracts deployment. It deploys Index contracts for vesting creator, recipient, and TIP-3 token.
NativeVesting — vesting contract for native tokens. Should be fulfilled with direct deposit.
Vesting — vesting contract for TIP-3 tokens. Should be fulfilled with a callback of the TIP-3 deposit.
Roles
Only the vesting recipient specified on deployment is able to withdraw vested funds.
Any user is able to create and fulfill vesting.
Executive Summary
Documentation quality
The total Documentation quality score is 10 out of 10.
A description of system functionality is provided.
The technical description is comprehensive.
Code quality
The total Code quality score is 9 out of 10.
Magic numbers usage is found.
Style guide violations are found.
The development environment is configured.
Test coverage
Code coverage of the project is 85%.
Some minor view functions are not tested thoroughly. Check if all the implemented functions are called and the return values are checked.
Missing access control tests for callbacks.
Security score
Upon auditing, the code was found to contain 1 critical, 0 high, 1 medium, and 2 low severity issues. Out of these, 2 issues have been addressed and resolved, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 9.3. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
Depending on TIP-3 token implementation funds may get stuck in case not enough value is attached to the call (especially during performing a deposit to the Vesting contract).
In case of the Gas price change, the minimal attached amount may be not enough for performing the execution of the whole call chain.
Users may be unable to retrieve the list of their vestments on-chain.
In case the vesting period is overlong, vesting contracts may need additional funding to not be frozen.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2023-1680 | Transaction Replay Attack | fixed | Critical | |
| F-2023-1681 | Inconsistent Gas Management | mitigated | Medium | |
| F-2023-168 | Outdated Compiler Version | mitigated | Low | |
| F-2023-168 | Floating Pragma | fixed | Low | |
| I-2023-043 | Redundancies | fixed | Observation | |
| I-2023-0435 | Redundancies | mitigated | Observation | |
| I-2023-043 | Incorrect File Extension | unfixed | Observation | |
| I-2023-043 | Style Guide Violation | unfixed | Observation | |
| I-2023-043 | Implicit Call Flag | fixed | Observation | |
| I-2023-043 | Magic Numbers Usage | unfixed | Observation |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/venom-blockchain/vesting→ |
| Commit | 871af51db9c58c8054cb144aea0d4c2f368f692b |
| Requirements | Provided→ |
Scope Details
- Commit
- 871af51db9c58c8054cb144aea0d4c2f368f692b
- Requirements
- Provided→