Audit name:
[SCA] uStaking | Staking | Mar2023
Date:
Mar 15, 2023
Table of Content
Introduction
We express our gratitude to the uStaking team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
uSTAKING is the decentralized staking platform run by a smart contract to maintain a deficit tokenomic model. This solution allows any entity/person to stake crypto assets for a long-term period and create the DeFi passive income.
| title | content |
|---|---|
| Platform | BNB Chain |
| Language | Solidity |
| Tags | BEP20, Staking |
| Timeline | 25/02/2023 - 14/03/2023 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/Ustaking/Contracts→ |
| Commit | 31b93f58e86d056557992117897b460a688d1762 |
Review Scope
- Repository
- https://github.com/Ustaking/Contracts→
- Commit
- 31b93f58e86d056557992117897b460a688d1762
Audit Summary
10/10
100%
10/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for uStaking |
| Audited By | Hacken |
| Website | https://ustaking.io/→ |
| Changelog | 01/03/2023 – Initial Review |
| 14/03/2023 – Second Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for uStaking
- Audited By
- Hacken
- Website
- https://ustaking.io/→
- Changelog
- 01/03/2023 – Initial Review
- 14/03/2023 – Second Review
System Overview
uStaking is a mixed-purpose system with the following contracts:
UStakingToken — simple ERC-20 token that mints all initial supply to a deployer. Additional minting is allowed to an address with a
MINTER_ROLE. There is an additional administrative role calledPAUSER_ROLE, addresses with this role can pause or unpause the transfer of tokens. There is a set token max supply (2000000000).UStaking — a contract that rewards users for staking their tokens. Users can choose the duration of staking, and a longer duration equals a bigger profit per day.
Privileged roles
PAUSER_ROLEis the only role with a permission to pause and unpause transfers of the uStakingToken.MINTER_ROLEis the only role with permission to mint new uStakingToken.DEFAULT_ADMIN_ROLEis the only role with permission to grant and revoke other roles to users of uStakingToken.
Executive Summary
Documentation quality
The total Documentation quality score is 10 out of 10.
Functional requirements are provided.
Technical description is provided.
NatSpec for UStaking and UStaking is provided.
Code quality
The total Code quality score is 10 out of 10.
No Solidity Style Guide violations are present.
Code follows best practices.
Development environment is provided.
Test coverage
Code coverage of the project is 100% (branch coverage).
Security score
Upon auditing, the code was found to contain 0 critical, 1 high, 5 medium, and 9 low severity issues. Out of these, 15 issues have been addressed and resolved, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 10. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2023-1383 | Funds Lock | fixed | High | |
| F-2023-1388 | Checks-Effects-Interactions Pattern Violation | fixed | Medium | |
| F-2023-138 | Copypasting Of Template Contracts | fixed | Medium | |
| F-2023-1386 | Requirements Compliance | fixed | Medium | |
| F-2023-138 | SafeMath in ^0.8.0 | fixed | Medium | |
| F-2023-138 | Same checks in functions | fixed | Medium | |
| F-2023-1397 | Missing event | fixed | Low | |
| F-2023-1396 | State variables default visibility | fixed | Low | |
| F-2023-139 | Style Guide Violation - Naming Conventions | fixed | Low | |
| F-2023-139 | Functions that can be declared external | fixed | Low |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/Ustaking/Contracts→ |
| Commit | 31b93f58e86d056557992117897b460a688d1762 |
| Whitepaper | Provided |
| Requirements | Provided |
| Technical Requirements | Provided |
Scope Details
- Repository
- https://github.com/Ustaking/Contracts→
- Commit
- 31b93f58e86d056557992117897b460a688d1762
- Whitepaper
- Provided
- Requirements
- Provided
- Technical Requirements
- Provided