Audit name:
[SCA] Sock | ERC4337 Implementation | Nov2023
Date:
Dec 4, 2023
Table of Content
Introduction
We express our gratitude to the Sock team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Sock is a mobile investing app that helps you invest crypto safely. Available on iOS and Android.
| title | content |
|---|---|
| Platform | EVM |
| Language | Solidity |
| Tags | Authorization, ERC-4337 |
| Timeline | 24/11/2023 - 05/12/2023 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/SockFinance/sock-account→ |
| Commit | 0ba8d366dc7f386539f7e11037fda8ee7ce90223 |
Review Scope
- Commit
- 0ba8d366dc7f386539f7e11037fda8ee7ce90223
Audit Summary
10/10
100%
10/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for Sock |
| Audited By | Arda Usman - SC Lead Auditor at Hacken OÜ |
| Kornel Światłowski - SC Auditor at Hacken OÜ | |
| Approved By | Grzegorz Trawiński - SC Audits Expert at Hacken OÜ |
| Website | https://www.sock.app/→ |
| Changelog | 27/11/2023 - Preliminary Report |
| 05/12/2023 - Final Report |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Sock
- Audited By
- Arda Usman - SC Lead Auditor at Hacken OÜ
- Kornel Światłowski - SC Auditor at Hacken OÜ
- Approved By
- Grzegorz Trawiński - SC Audits Expert at Hacken OÜ
- Website
- https://www.sock.app/→
- Changelog
- 27/11/2023 - Preliminary Report
- 05/12/2023 - Final Report
System Overview
Sock is an ERC-4337 compliant contract implementation, and is designed to allow for self-custody storage of cryptocurrencies in a safe and controlled space. It has the following contracts:
SockRegistryAccessManager - Contract module that provides access control mechanisms over the sock function registry.
SockFunctionRegistry - A registry contract to manage allowed and disallowed functions and their properties.
SockUserPermissions - Abstract contract module to handle user permissions.
SockOwnable - Provides access control mechanisms with two types of owners - 'owner' and 'sockOwner'. The 'owner' and 'sockOwner' can have distinct rights and the distinction allows functions to be restricted to either of them or both.
Privileged roles
Owner: Maximal amount of control with the ability to change all other roles within the contract.
Executive Summary
Documentation quality
The total Documentation quality score is 10 out of 10.
Functional requirements are provided.
Technical description is provided.
Code quality
The total Code quality score is 10 out of 10.
Test coverage
Code coverage of the project is 100% (branch coverage).
Deployment and basic user interactions are covered with tests.
Security score
Upon auditing, the code was found to contain 0 critical, 1 high, 0 medium, and 1 low severity issues. Out of these, 2 issues have been addressed and resolved, leading to a Security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 10. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2023-0864 | Missing Constructor And Assignment Of Admins In SockOwnable | fixed | High | |
| F-2023-0865 | Missing Zero Address Validation | fixed | Low | |
| I-2023-0215 | Gas Inefficient Counter | fixed | Observation | |
| I-2023-0214 | Higher Deployment Cost Due To Complex Implementation Of _getFunctionSig() | fixed | Observation | |
| I-2023-0213 | Floating Pragma | fixed | Observation |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/SockFinance/sock-account→ |
| Commit | 0ba8d366dc7f386539f7e11037fda8ee7ce90223 |
| Whitepaper | Not provided |
| Requirements | Provided |
| Technical Requirements | Provided |
Scope Details
- Commit
- 0ba8d366dc7f386539f7e11037fda8ee7ce90223
- Whitepaper
- Not provided
- Requirements
- Provided
- Technical Requirements
- Provided