Audit name:
[SCA] RedFox | NFT | Sep2021
Date:
Sep 22, 2021
Table of Content
Introduction
We express our gratitude to the RedFox team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Velocore is a groundbreaking solution, synthesizing top-tier DEX methodologies into a novel, high-performance flywheel
| title | content |
|---|---|
| Platform | NAME |
| Language | NAME |
| Tags | NAME |
| Timeline | - - - |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/velocore/audit→ |
| Commit | 94fc760 |
Review Scope
- Repository
- https://github.com/velocore/audit→
- Commit
- 94fc760
Audit Summary
6/10
68%
6/10
6/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for RedFox |
| Audited By | |
| Approved By | |
| Website | https://hacken.io→ |
| Changelog | 30/01/2024 - Preliminary Report |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for RedFox
- Audited By
- Approved By
- Website
- https://hacken.io→
- Changelog
- 30/01/2024 - Preliminary Report
System Overview
PROJECT_NAME is a staking protocol with the following contracts:
Token — simple ERC-20 token that mints all initial supply to a deployer. Additional minting is not allowed.
It has the following attributes:
Name: TokenName
Symbol: TST
Decimals: 18
Total supply: 100m tokens.
Staking — a contract that rewards users for staking their tokens. APY depends on the tokens provided by the owner and could not be calculated before reward tokens are deposited.
Privileged roles
The owner of the contract can arbitrarily add, delete and modify the addresses stored. It is therefore entitled to impersonate or change the logic of critical components of the system at will.
The owner can revoke a vesting if upon creation such a parameter was provided. On revoking all vested tokens till the moment are automatically released to the beneficiary account.
Executive Summary
Documentation quality
The total Documentation quality score is 2 out of 10.
Functional requirements are partially missed.
Technical description is not provided.
Code quality
The total Code quality score is 3 out of 10.
The code duplicates commonly known contracts instead of reusing them.
Several template code patterns were found.
The development environment is configured.
Test coverage
Code coverage of the project is 17.99% (branch coverage), with a mutation score of 77%.
Deployment and basic user interactions are covered with tests.
Negative cases coverage is missed.
Interactions by several users are not tested thoroughly.
Security score
Upon auditing, the code was found to contain 0 critical, 0 high, 0 medium, and 2 low severity issues. Out of these, 2 issues have been addressed and resolved, leading to a security score of 5 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 4.3. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
Iterating over a dynamic array populated with custom tokenId can lead to gas limit denial of service if the number of tokenId goes out of control.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2022-1919 | A public function that could be declared external | fixed | Low | |
| F-2022-1918 | A State variable that could be declared immutable | fixed | Low |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/hknio→ |
| Commit | f185c31beaace0671972d1c2c5be6ea67a8a55e9 |
| Whitepaper | https://hackenio.cc/hacken-methodologies→ |
| Requirements | |
| Technical Requirements |
Scope Details
- Repository
- https://github.com/hknio→
- Commit
- f185c31beaace0671972d1c2c5be6ea67a8a55e9
- Requirements
- Technical Requirements