Audit name:
[SCA] Ociswap | AVL Tree | Jan2023
Date:
Jan 18, 2024
Table of Content
Introduction
We express our gratitude to the Ociswap team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
Ociswap AVLTree is a scalable implementation of a binary tree structure in Scrypto.
| title | content |
|---|---|
| Platform | Radix DLT |
| Language | Rust, Scrypto |
| Timeline | 17/10/2023 - 16/01/2024 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Type: AVL Tree
Review Scope | |
|---|---|
| Repository | https://github.com/ociswap/scrypto-avltree→ |
| Commit | 254a7ab209bd928462509f7ca1dcf7b05add4094 |
Review Scope
- Commit
- 254a7ab209bd928462509f7ca1dcf7b05add4094
Audit Summary
10/10
100%
10/10
10/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for Ociswap |
| Audited By | Hacken |
| Website | https://ociswap.com/→ |
| Changelog | 20/11/2023 – Preliminary Report |
| 17/01/2024 – Remediation Check |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for Ociswap
- Audited By
- Hacken
- Website
- https://ociswap.com/→
- Changelog
- 20/11/2023 – Preliminary Report
- 17/01/2024 – Remediation Check
System Overview
AvlTree - is a radix-specific library implementation of a balanced binary tree structure in Scrypto. It is able to overcome limitations of built-in Rust key-value maps since it is able to lazy load specific elements instead of loading the whole collection.
Executive Summary
Documentation quality
The total Documentation quality score is 10 out of 10.
Functional and technical requirements are provided in full.
Code is properly outlined with comments.
Code quality
The total Code quality score is 10 out of 10.
Test coverage
Code coverage of the project is 100% (branch coverage).
The code is thoroughly tested.
Security score
Upon auditing, the code was found to contain 0 critical, 0 high, 0 medium, and 1 low severity issues. Out of these, 0 issues have been addressed and resolved, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 10. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
Current implementation of the AVLTree has room for gas efficiency optimisations.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2023-1578 | Floating language version | accepted | Low | |
| I-2023-041 | AlvTree optimization to fix recomputation | accepted | Observation | |
| I-2023-041 | Unformatted Code | fixed | Observation | |
| I-2023-0410 | Vulnerable dependencies | fixed | Observation | |
| I-2023-0409 | Unnecessary pattern matching is redundant | fixed | Observation |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/ociswap/scrypto-avltree→ |
| Commit | 254a7ab209bd928462509f7ca1dcf7b05add4094 |
| Whitepaper | Not provided |
| Requirements | Provided→ |
| Technical Requirements | Provided→ |