- Hacken
- Audits
- bytrade-venture-capital
- [SCA] ByTrade Venture Capital | Staking | Feb2023
Audit name:
[SCA] ByTrade Venture Capital | Staking | Feb2023
Date:
Mar 2, 2023
Table of Content
Introduction
We express our gratitude to the ByTrade Venture Capital team for the collaborative engagement that enabled the execution of this Smart Contract Security Assessment.
ByTrade is continuously developing a complete ecosystem in the virtual asset and blockchain technology environment.
| title | content |
|---|---|
| Platform | EVM |
| Language | Solidity |
| Tags | Staking |
| Timeline | 20/02/2023 - 03/03/2023 |
| Methodology | https://hackenio.cc/sc_methodology→ |
Review Scope | |
|---|---|
| Repository | https://github.com/bytradeio/Bytrade-Staking→ |
| Commit | 00cc24ea2bdbe16a77237b64b9f6b35da0acae00 |
Review Scope
- Commit
- 00cc24ea2bdbe16a77237b64b9f6b35da0acae00
Audit Summary
10/10
0.00%
8/10
8/10
The system users should acknowledge all the risks summed up in the risks section of the report
Document Information
This report may contain confidential information about IT systems and the intellectual property of the Customer, as well as information about potential vulnerabilities and methods of their exploitation.
The report can be disclosed publicly after prior consent by another Party. Any subsequent publication of this report shall be without mandatory consent.
Document | |
|---|---|
| Name | Smart Contract Code Review and Security Analysis Report for ByTrade Venture Capital |
| Audited By | Hacken |
| Website | https://bytrade.io/→ |
| Changelog | 24/02/2023 - Initial Review |
| 03/03/2023 - Second Review |
Document
- Name
- Smart Contract Code Review and Security Analysis Report for ByTrade Venture Capital
- Audited By
- Hacken
- Website
- https://bytrade.io/→
- Changelog
- 24/02/2023 - Initial Review
- 03/03/2023 - Second Review
System Overview
ByTrade Venture Capital is a system with the following contracts:
BytradeStaking_ — a contract that rewards users for staking their tokens. APY depends on the tokens provided by the owner and cannot be calculated before reward tokens are deposited.
Privileged roles
The contract does not have any privileged roles.
Executive Summary
Documentation quality
The total Documentation quality score is 8 out of 10.
Overall system requirements are provided.
NatSpec is insufficient.
Run instructions are provided.
Code quality
The total Code quality score is 8 out of 10.
Best practices violations.
Test coverage is insufficient.
Test coverage
Code coverage of the project is 0.00% (branch coverage).
Code is not covered with tests.
Security score
Upon auditing, the code was found to contain 0 critical, 2 high, 1 medium, and 5 low severity issues. Out of these, 6 issues have been addressed and resolved, leading to a security score of 10 out of 10.
All identified issues are detailed in the “Findings” section of this report.
Summary
The comprehensive audit of the customer's smart contract yields an overall score of 9.6. This score reflects the combined evaluation of documentation, code quality, test coverage, and security aspects of the project.
Risks
The view function returns a dynamic array of unlimited size. It is theoretically possible that the Gas cost of executing this function will exceed the Gas limit set in the node.
Smart contract is available to receive Ether, but it is not necessary for it to work.
Findings
Code ― | Title | Status | Severity | |
|---|---|---|---|---|
| F-2023-0010 | Insufficient Balance | fixed | High | |
| F-2023-0009 | Funds Lock | fixed | High | |
| F-2023-0011 | Gas Limit and Loops | fixed | Medium | |
| F-2023-0016 | Variables that Should Be Declared External | unfixed | Low | |
| F-2023-0015 | Use of Hard-Coded Values | unfixed | Low | |
| F-2023-0014 | Use of Hard-Coded Values | fixed | Low | |
| F-2023-0013 | Boolean Equality | fixed | Low | |
| F-2023-0012 | Floating Pragma | fixed | Low |
Appendix 1. Severity Definitions
When auditing smart contracts, Hacken is using a risk-based approach that considers Likelihood, Impact, Exploitability and Complexity metrics to evaluate findings and score severities.
Reference on how risk scoring is done is available through the repository in our Github organization:
Severity | Description |
|---|---|
Critical | Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation. |
High | High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation. |
Medium | Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category. |
Low | Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score. |
Severity
- Critical
Description
- Critical vulnerabilities are usually straightforward to exploit and can lead to the loss of user funds or contract state manipulation.
Severity
- High
Description
- High vulnerabilities are usually harder to exploit, requiring specific conditions, or have a more limited scope, but can still lead to the loss of user funds or contract state manipulation.
Severity
- Medium
Description
- Medium vulnerabilities are usually limited to state manipulations and, in most cases, cannot lead to asset loss. Contradictions and requirements violations. Major deviations from best practices are also in this category.
Severity
- Low
Description
- Major deviations from best practices or major Gas inefficiency. These issues will not have a significant impact on code execution, do not affect security score but can affect code quality score.
Appendix 2. Scope
The scope of the project includes the following smart contracts from the provided repository:
Scope Details | |
|---|---|
| Repository | https://github.com/bytradeio/Bytrade-Staking→ |
| Commit | 00cc24ea2bdbe16a77237b64b9f6b35da0acae00 |
| Whitepaper | Provided→ |
| Requirements | Provided→ |
| Technical Requirements | Not provided |